[Draft] WIP close prompt on download [skip ci]#1022
Open
vsangereanMOZ wants to merge 2 commits intomainfrom
Open
[Draft] WIP close prompt on download [skip ci]#1022vsangereanMOZ wants to merge 2 commits intomainfrom
vsangereanMOZ wants to merge 2 commits intomainfrom
Conversation
Collaborator
Author
|
MOVED TO ANOTHER |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant Links
Bugzilla: _
TestRail: _
Description of Code / Doc Changes
Made multiple attempts at test.
What I have tried:
Nothing seemed to be realiable, since when FF did try to close, I could not get focus back to check the dialogue.
Process Changes Required
Mark the relevant boxes, delete irrelevant lines.
pipenv install)./devsetup.sh)Screenshots or Explanations
If you need to explain your code, do it here.
Comments or Future Work
Do we need to start another PR soon to address something you saw while working on this?
Workflow Checklist
Thank you!